TUDelft-CITG / OpenCLSim

Rule driven scheduling of cyclic activities for in-depth comparison of alternative operating strategies.
https://openclsim.readthedocs.io
MIT License
14 stars 16 forks source link

Wibo critical path cosmetics #127

Open GerbenJdeBoer opened 1 year ago

GerbenJdeBoer commented 1 year ago

Please have a look at this example: it combines occupancy analysis with critical path.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Pietervanhalem commented 1 year ago

image

This basic activity is optional. Its not wrong or anything but it does not nessescary make sense to have a basic activity there. So you might get better figures if you remove this.

Pietervanhalem commented 1 year ago

I dont see issues with the container reservations Looks good!

Pietervanhalem commented 1 year ago

To me the occupancy analysis also seems good! Nice job:

I did:

results = []
for i in range(len(barge_names)):
    results.append(run(i+1,total_amount)) # at least 1 barge
    vessels = results[i]['vessels']
    activities = results[i]['activities']
    cutter = vessels[cutter_name]
    to_site = results[i][to_site_name]
    from_site = results[i][from_site_name]
    df = occupancy_analysis(vessels, cutter, activities)
    display(df)

so I can see the dataframes as well. Really nice to see that the cutter occupancy goes up but the barge occupancy goes down when you have more barges.

Very nice!

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 35 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication