OpenTNSim OpenCLSim connection

[SiggyF]

• [x] Rename routeable -> routable (opentnsim)
• [x] Add assumptions for env (.graph (preferred) or .FG)
• [x] Add typed arguments for destination (shapely.Geometry, should be along the route for routables), engine_order (float) and duration (overrides v based duration computation).
• [x] Make types compatible between opentnsim and opentlsim
  • [x] add optional node to locatable
  • [x] support both openclsim and opentnsim compatible logging
• [x] Split routable based moving vs non routable moving (always over Linestring), routable determines linestring, simple sailing is over linestring (source, destination)
• [x] Support routing over geometries (geometries as network nodes)
• [x] Explicitly define data model for nx.Graph to be able to route over it

(commits moved from https://github.com/TUDelft-CITG/OpenCLSim/pull/116)

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
1.4% Duplication

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[luke-moth]

@SiggyF looks good :)

• zojuist review besproken.
• op dit moment twee TODOS (code smells) en de falende (black) tests.
• notebooks bekeken en los van comments in notebook 33 (mijn reviewNB comment hierboven mbt 'a lot of comments') geen commentaar, zijn duidelijk/volgens structuur OpenCLSIm notebooks.

Na reactie/aanpassing op bovenstaande zal ik approven (en verwacht ik inderdaad dat je wat merge conflicts zal krijgen zoals je ook al had gezegd - succes ;))

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[github-actions[bot]]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-cliff-0e49c3503-129.westeurope.1.azurestaticapps.net

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information