TUDelft-CITG / OpenCLSim

Rule driven scheduling of cyclic activities for in-depth comparison of alternative operating strategies.
https://openclsim.readthedocs.io
MIT License
14 stars 16 forks source link

OpenCLSim routing using path and route #147

Closed SiggyF closed 3 months ago

SiggyF commented 7 months ago
review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

GerbenJdeBoer commented 5 months ago

I added some cosmetic changes in 2 notebooks. The notebook 32_openclsim_routing.ipynb seems not necesarry, it is a bare version of 32_openclsim_opentnsim_moving.

Nice that pure OpenCLSim can use both a path and a graph. This removes the need to use OpenTNSim if you want to sail over routes in OpenCLSim.

GerbenJdeBoer commented 5 months ago

I updated notebook cosmetics, but the latest tests now seem to fail on datetime durations. It seems that the Critical path code yields periods in total_seconds * 1000000000 instead of datetimes.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud