search

TUDelft-CITG / OpenCLSim

Rule driven scheduling of cyclic activities for in-depth comparison of alternative operating strategies.
https://openclsim.readthedocs.io
MIT License
14 stars 17 forks source link

log waiting on weather or specific event #83

Closed majstrooker closed 3 years ago

majstrooker commented 4 years ago

Makes specific logging of waiting on weather (WoW) event possible. Therefore, e.g., specific WoW events can be plotted seperately.

majstrooker commented 4 years ago

@uijl Nice work! However I would like to suggest some changes as discussed earlier.

I would prefer to keep only the initial changes to logging specific WoW events seperate in this PR. Therefore I would like to reset the changes in this PR to commit cdb923e.

In my opinion there are 3 issues that have been solved now:

  1. logging of specific WoW event
  2. events are executed at correct site
  3. use of subcycles is fixed

Some changes to solve problems 2 and 3 (specifically commit 8af8782) have made adjustments to the solving of problem 1 however. And so the commits for the problems that were solved have gotten mixed up a bit. Therefore I suggest the following.

First a new branch will be made from this branch. This branch will then reset to commit cdb923e and if those changes are approved, we will merge and close this PR. From then on, a new PR will be created with the new branch, and so merging commits after cdb923e.

This way the commit- and PR history is kept clean. Also reviewing smaller PR's in general will be more manageable, leading to more catching of bugs and nice comments/suggestions!

EDIT: In addition, if you already want to use this code in another app, or another peace of code, you can already make a new release. This will then be an alpha-release of the v1.2.0 release. In other words you can already make a release called v1.2.0a1 with this branch at its current state.

EDIT2: As there already is a release with tag v1.2.0 I made a release called v1.3.0a1 to use this code already.