search

TUDelftGeodesy / stmtools

Xarray extension for Space-Time Matrix
https://tudelftgeodesy.github.io/stmtools/
Apache License 2.0
7 stars 0 forks source link

update and apply ruff standards #52

Closed rogerkuou closed 1 year ago

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.4% 89.4% Coverage
0.0% 0.0% Duplication

rogerkuou commented 1 year ago

Hi @SarahAlidoost, I implemented more checks by ruff. In summary:

  1. I removed a wrong implementation "density" in subset function. This implementation was implemented as a draft in the beginning, turned out has flaws and I did not add test and docs for it. I documented an issue #14 for this for later work.
  2. Added more tests for stm.py
  3. Renamed a varaible in add_metadata in stm.py from "points" to "dimension", to make it consistent with the simension name
  4. Other formatting problems

Could you please view it?