TUDelftGeodesy / stmtools

Xarray extension for Space-Time Matrix
https://tudelftgeodesy.github.io/stmtools/
Apache License 2.0
6 stars 0 forks source link

Add a function to enrich STM using data from another dataset #66

Closed SarahAlidoost closed 4 months ago

SarahAlidoost commented 6 months ago

closes #63

This PR implements two functions:

see #69 on why I changed_io.py in this PR.

SarahAlidoost commented 5 months ago

Hi Sarah, thanks for the nice implementation! It works well in general.

I have two comments regarding adding more checks on the incoming data. See above.

These comments come from a test I made with KNMI data. I also attached the notebook and the small example dataset here.

example_test.zip

thanks for the review. It is ready for another look.