TUM-DAML / seml

SEML: Slurm Experiment Management Library
Other
165 stars 29 forks source link

Evaluate project_root_dir relative to config_dir #104

Closed heborras closed 1 year ago

heborras commented 1 year ago

Reference issue

None created yet.

What does this implement/fix?

The most recent commit e340dc4de0c472839fdda811e8b90d69fd6e54e0 introduces a new way of changing the working directory, when adding config files. Unfortunately a bug seems to have sneaked in, when evaluating the project_root_dir config variable. This is now evaluated relative to the current working directory of wherever seml was called from and not relative to the config as it was before. This means that if project_root_dir was previously set to a valid path when evaluated relative to the config (as in the examples) then this is now broken depending on where seml was called from. At least in my case where I have multiple folders of configuration files this broke all config files. Evaluating the project_root_dir relative to the config_dir fixes the bug.

n-gao commented 1 year ago

LGTM. Thank you for fixing this!