TUM-DAML / seml

SEML: Slurm Experiment Management Library
Other
165 stars 29 forks source link

init typing #138

Closed n-gao closed 2 weeks ago

n-gao commented 1 month ago

This PR adds typing support to seml. It also adds pyright to CI and pre-commit. For syncing the pre-commit dependencies we have a small script that will automatically pull the right dependencies from the pyproject.toml.

n-gao commented 3 weeks ago

I changed a bunch of development and CI settings to cover Python and package versions better. I made the following changes:

n-gao commented 2 weeks ago

I also added very rudimentary support for non-conda environments by simply ignoring site-packages when uploading source files. Afaik, seml should just work fine without a conda environment since at the time of submitting a job, slurm will copy all environment variables anyway from the current shell. An issue arises if the virtual environment that submits the slurm job is not the same as the one is called add. I guess there are several options: