search

TUM-DAML / seml

SEML: Slurm Experiment Management Library
Other
165 stars 29 forks source link

`seml jupyter` determining host name for `jupyter --ip <host>` not ideal #86

Closed sigeisler closed 2 years ago

sigeisler commented 2 years ago

Expected Behavior

seml jupyter relies on https://github.com/TUM-DAML/seml/blob/master/seml/jupyter_template.sh#L20 to determine the FQDN. However, the FQDN is neither necessarily unique nor is the first entry of hostname --all-fqdn a reliable way of determining the hostname (e.g. see https://www.computerhope.com/unix/uhostnam.htm#The-FQDN "Do not make any assumptions about the order of the output.").

Thus, I suggest sacrificing readability and using the plain IP address.

n-gao commented 2 years ago

An alternative to the IP would be to listen to 0.0.0.0 which listens to all incoming traffic. This is generally not recommended for servers but since we're working in a closed cluster it may be appropriate