"My Grades" errors when no grades are available - Githubissues

TUM-Dev / Campus-Android

Development of the TUM Campus App for Android devices - for and from students at Technical University of Munich.

https://app.tum.de

GNU General Public License v3.0

208 stars 86 forks source link

"My Grades" errors when no grades are available #1430

Closed ctsk closed 2 years ago

ctsk commented 2 years ago

Steps to Reproduce

Be enrolled at TUM but have no exams written yet
Connect to TUM Online
Open "My Grades"

Expected Result

Something like "No grades available"

Actual Result

"Unknown Error"

Problem

Probably relates to https://github.com/Tickaroo/tikxml/issues/155

TUMOnline returns an empty list
tikxml parses this to a null
value which makes the kotlin runtime complain as in https://github.com/TUM-Dev/Campus-Android/blob/3772bf29d937b44dacf75d58523d6b54ea1c8e28/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/grades/model/ExamList.kt#L13 exams may not be null

Suggested Enhancement :sparkles:

Either:

Fix TikXml (I've got no clue how to do that)

or:

make ExamList.exams nullable
Add null checks in these methods
- https://github.com/TUM-Dev/Campus-Android/blob/3772bf29d937b44dacf75d58523d6b54ea1c8e28/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/grades/GradesFragment.kt#L101
- https://github.com/TUM-Dev/Campus-Android/blob/3772bf29d937b44dacf75d58523d6b54ea1c8e28/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/grades/GradesBackgroundUpdater.kt#L28

Environment

Phone: Pixel
OS version: 12
TUM Campus App version: v3.13
Language: English

ctsk commented 2 years ago

Fixed in #1431