search

TUM-Dev / Campus-Android

Development of the TUM Campus App for Android devices - for and from students at Technical University of Munich.
https://app.tum.de
GNU General Public License v3.0
209 stars 86 forks source link

Mensa opening hours are wrong/outdated #1440

Open ManuelHu opened 2 years ago

ManuelHu commented 2 years ago

Expected Result

The opening hours of the mensa matches the ones specified by the Studentenwerk. So for Garching, the opening hours shoukd be 11:00-14:00 on Monday till Friday.

Actual Result

Opening hours 

Mo-Do 11-16, Fr 11-13:45\nvorl.freie Zeit
Mo-Do 11-14\nFr11-13:45

Also in the menu view, the wrong end time (16:00) is used for calculations.

Problem

The opening hours are outdated (at least since some semesters, I suppose...) and do not match the real ones...

Environment

kmodexc commented 2 years ago

Seems to be a backend issue:

{
    "id": "66",
    "category": "cafeteria_gar",
    "name": "Mensa Garching",
    "address": "Lichtenbergstr. 2, 85748 Garching",
    "room": "",
    "transport_station": "",
    "opening_hours": "Mon-Thu 11-16, Fri 11-13:45\nLecture free period:\nMon-Thu 11-14 Fri 11-13:45",
    "infos": "Payment: Legic-Card",
    "url": "https://www.studentenwerk-muenchen.de/mensa/standorte-und-oeffnungszeiten/garching/#c1430",
    "language": "en",
    "reference_id": "422"
  }
kmodexc commented 2 years ago

I will create an eat-api client.

CommanderStorm commented 2 years ago

I will create an eat-api client.

you should have a look at https://github.com/TUM-Dev/Campus-Android/pull/1422 and what the status of this PR is. There is already a lot of work, that has been done by @Liqs-v2

Woulld be a shame to do the same work twice..

Liqs-v2 commented 2 years ago

@kmodexc I would wait for work on the cafeteria part until the eat-api PR is merged. It will still not be fully done yet, as that is a large section of the app, but that issue might just fix itsself then.

joschahenningsen commented 2 years ago

I changed the backends opening hours, thanks for reporting, feel free to ping me if any other times are off :)

ManuelHu commented 2 years ago

Thanks for updating the opening hours, @joschahenningsen . Also the Espressobar and all other StuCafes in Garching are not correct.

Also the addresses are outdated, the C2 Campus-Cneipe, Mensa Garching, Mensa Garching Infopoint & StuCafé Mensa Garching are now at Boltzmannstraße 19 instead of Lichtenbergstraße 2, which is the old mensa building...

I did not check the other campuses, but I suspect the opening ours also to be outdated.

Bentipa commented 2 years ago

Is this going to be fixed through the eat-api? @joschahenningsen

kordianbruck commented 2 years ago

Yes, most likely. Eat-api has newer information and we can throw away the old obsolete stuff then