TUM-Dev / Campus-Backend

New backend written in go with gRPC as an API interface
GNU General Public License v3.0
15 stars 7 forks source link

[BUG] clicking on news does not open news source #344

Open Pydes-boop opened 7 months ago

Pydes-boop commented 7 months ago

Describe the bug Currently when clicking on news in the news tab of the app it does not redirect or open the origin of the news but instead just opens a full view of the preview image.

To Reproduce Steps to reproduce the behavior:

  1. Go to Home
  2. Scrill down to News
  3. Click on any news

Expected behavior When clicking on a news article i want to be able to read more context about it or open the source in a browser window.

CommanderStorm commented 7 months ago

What news are you clicking on? (can you attach a screenshot) For some of our news, no browser window exists (the ones whith the blue half of the screen, i.e. "newsspread")

Idk, if there are good solutions to scrape the text from these images and check if some of the contained text is a link => link there..

CommanderStorm commented 7 months ago

Transferred to the backend, as this is likely where the issue comes from.

Pydes-boop commented 7 months ago

Sorry some additional info: Right now im on App Version 5.0.1 and im experiencing it when clicking on any news in the tab "latest news"

for example tum thesis printing, but also Talk Food Texture Engineering, Drachenbootrennen and all others i see in the latest news tab.

I think it would be nice if it just opened the source it is referncing at the bottom of the news text.

For the TU Film it works correctly and opens the link when clicking on the different movies.

image

image

jakobkoerber commented 7 months ago

I can offer some insights into this: in the beginning we opened the corresponding URL in an In-App-Webview. But after, presumably, changes to the backend the URL was always a link to the password-protected newsspread site. To offer at least some better way to display the information we opted for a full-screen image view. I don't think scraping the image on the client-side would be smart due to performance reasons, we could do that in the backend. If possible, I would opt to bring back public URLs. In general, I was thinking about moving solely to the TUM RSS since these are the only news that affect every student of TUM and are not faculty-specific. But that's another matter 😄

imo this is therefore also not a bug ^^

CommanderStorm commented 7 months ago

Tum's feed does contain lots of "less related" things (Read: PR). These screens are a better data source imo

=> lets discuss the approach for news parsing on the next team meeting.

jakobkoerber commented 7 months ago

These screens are a better data source imo

I think that's debatable but we could think about filtering a bit more depending on the degree of the user. But yes, let's discuss that next meeting :)