TUM-Dev / NavigaTUM

Navigating around TUM with excellence – A website and API to search for rooms, buildings and other places
https://nav.tum.de
GNU General Public License v3.0
48 stars 9 forks source link

[Feature] Site Maps Zoom #143

Closed CommanderStorm closed 1 year ago

CommanderStorm commented 2 years ago

Is your feature request related to a problem? Please describe. The Site Maps are pretty small. Especially for older folks/ people with disabilitys this represents a significant hurdle. As the text on the image has a fixed size. image

Describe the solution you'd like For accassability it may be nice to offer an option for users to zoom into the image/pop it out like for headline images.

i.e. I would prefer a solution like this: image

Describe alternatives you've considered In the long term, we are reducing our reliance on these maps anyway as they offer imo worse UX than the map, but sometimes having the extra context of a site-map may be nice.

Additional context Not a active issue for the person, who suggesed this but something he found a nice to add.

Marius1501 commented 2 years ago

Hi, I would like to adopt this task. Could you please assign it to me? Thanks.

octycs commented 2 years ago

Sure :) the only thing is @CommanderStorm is planning the migration to vue3, so I hope this doesn't conflict.

Marius1501 commented 2 years ago

This issue is already implemented, isn`t it? 😄

CommanderStorm commented 2 years ago

This issue is already implemented, isn`t it?

No, this is still open. When clicking on the Site-Plans a modal should pop out/ it should be possible to zoom in, or what are you referring to?

Marius1501 commented 2 years ago

Oh yes sorry, I was confused. My problem is that I am not able to test my code. Because on http://localhost:8000/build/index-view-main-light-de.html I only get the main page with a network failure. But I need one page with the roomfinder-map. How can I solve this?

CommanderStorm commented 2 years ago

My problem is that I am not able to test my code. How can I solve this?

Usually, this means that the API is down. Can you check this by navigating to https://nav.tum.de/api/source_code , localhost:8080/api/get/root and localhost:8080/api/search?q=mi?

What does your web browsers console put out? Are there warnings?

Note that if you are trying to use our public API, this won't work until #259 is merged.

Marius1501 commented 2 years ago

For https://nav.tum.de/api/source_code I get https://github.com/TUM-Dev/navigatum/tree/1a878722583d3e9161da3d62b29e1c6df2b78572 back. For localhost:8080/api/get/root I get a connection error. And for localhost:8080/api/search?q=mi I get also a connection error. Do I have to do the server documentation? Or is this irrelevant for testing the webclient?

CommanderStorm commented 2 years ago

I don't know why our Project causes so many problems for you.

I get a connection error.

That sounds suspicious: What steps have you followed to get the API online?

More concretely (I am assuming you did run it locally and not via docker or prod):

I have done some work over on #268, if you have feedback where something is unclear, this would be highly appreciated 😅

Marius1501 commented 2 years ago

I am so sorry and very thankful for your patience with me. 😄 I thought at the beginning that I don`t need MeiliSearch. Now I set it up but on http://localhost:7700/ it says that "There’s no document in the selected index". And in the server terminal I get the following error code: grafik And on http://localhost:8000/build/index-view-main-light-de.html I get a 500 server error now.

I think I am very close that it is working. 😆

CommanderStorm commented 2 years ago

That is awkward… I have just read through our Server docs… Wow… We really fucked up there… That is really unfortunate how we documented this part… For example, we did not document how to get data/api_data.db. This has to improve moving forward @octycs, please hold me accountable to this promise if need be…

Until then, there are two options:

Thanks for finding all these issues. Telling us, where we are failing is incredibly helpful.

Marius1501 commented 2 years ago

Unfortunately is this code part not working. https://github.com/TUM-Dev/NavigaTUM/blob/e200bfe4e0609575f3a6b24c9dd30117a2df8e74/resources/scripts/regen.sh#L12-L19 When I want to execute python load_api_data_to_db.py I get a FileNotFoundError because there is no file data/api_data.json. Am I doing something wrong?

CommanderStorm commented 2 years ago

api_data.json is generated by regen.sh in the lines leading up to line 12, by following the data docs or by downloading it from the web. Which of these paths have you followed?

I am infering, that you ran regen.sh. What was the console output?

Marius1501 commented 2 years ago

grafik This was the output wen I ran python3 load_api_data_to_db.py. And when I want to copy api_data.json to ./server/data it says that I cannot access the file.

CommanderStorm commented 2 years ago

I have to confess, that I have no idea where you are currently and what you have done to this point. Please run the following to get me up to speed where you are currently at:

pwd # should print .../NavigaTUM/server
ls -lah ./data # should print the contents of .../NavigaTUM/server/data
ls -lah ../data/ouput # should print the contents of .../NavigaTUM/data/output

Just running load_api_data_to_db.py without generating the data is unfortunately not possible. As I tried to ask above, have you ran regen.sh, followed the data docs or downloaded it from the web?

Marius1501 commented 2 years ago

I downloaded it from the web. But now I got it working finally. 😄 Thank you very much for your patience! I hope I didn't steal that much of your time! Now I can work on it. 👍🏻

Marius1501 commented 2 years ago

I have just one more question. Do I have to do something when I change the code and run my test then? Because now nothing changes in my test environment when I change my code and save it. Or do I have to build the server new every time I have changes?

octycs commented 2 years ago

It depends on where you do the changes, but in general yes.