TUM-Dev / NavigaTUM

Navigating around TUM with excellence – A website and API to search for rooms, buildings and other places
https://nav.tum.de
GNU General Public License v3.0
48 stars 9 forks source link

[Feature] improved loading times for maps #39

Closed CommanderStorm closed 6 months ago

CommanderStorm commented 2 years ago

Is your feature request related to a problem? Please describe. Currently our loading times for the interactive maps are a bit slow. We should look into this.

Describe the solution you'd like Either (I am ushure if those two aproaches are compatible, this would be something to try out):

WebWorkers

Static Images

Possible Tools:

There are a lot more similar projects (just to dump them here):

Describe alternatives you've considered Stick with the current loadingtimes, as they are, at least for the current version, enough

CommanderStorm commented 2 years ago

I have some news considering this issue:

are the best combination from experimenting around a lot.

I am unsure if we should switch to static images. The main issue is that I don't like how the static images are blurry when zooming and that there appears to be no map implementation supporting both vector and static images. I don't think, that adding the complexity of another map just for this feature is worth it.

Furthermore, there seem to be some strange stuttering issues when loading new tiles. This could be because of tileserver-gl's preview, or because of some underlying issue for tileserver-gl. The best course of action is, probably, to add this as a (unofficial) deployment and see if Leaflet solves this issue.

If you (@octycs) are in the MI sometimes in the next few days, I can also show to you what I mean… I will be there because I have to work for a course's final submission πŸ˜†

I suppose at least for a better version of https://github.com/TUM-Dev/navigatum/blob/main/webclient/src/assets/logo-card.png this would be a good feature to have. πŸ˜‰

I will propose a PR adding a static endpoint in the next few days, and we can look from there.

Note that again Opera Mini is https://caniuse.com/?search=WebGL => in our current version, that browser is probably not usable in terms of performance, since this means it has to use a software renderer. => We should probably finally kill our support for this stupid browser (as said before 😜)

CommanderStorm commented 6 months ago

I tried prewarm, it did not improve performance (in fact it was worse) => not doing it

We switched to using a custom tileserver in #201 a while ago => are already using said performance improvemnt => lets close this issue as resolved