TUM-Dev / campus_flutter

Development of the cross-platform TUM Campus App with Flutter - for and from students at Technical University of Munich.
https://tum.app/
GNU General Public License v3.0
37 stars 4 forks source link

[BUG] Information Mismatch in Lecture Details #172

Closed Garfield96 closed 9 months ago

Garfield96 commented 9 months ago

Describe the bug The information shown in the lectures list is incorrect. The list shows a lecture for the next summer semester. However, there is no such lecture in TUMonline. Clicking on the lecture shows the data for the lecture, which took place in the winter term 2021/22. It looks like, the details page shows the information for the oldest occurrence of a lecture.

To Reproduce Steps to reproduce the behavior:

  1. Go to Lectures
  2. Open some lectures and compare information shown in the list with the information shown in the details

Expected behavior Information shown in the list should match the information shown in the details.

Screenshots

Smartphone (please complete the following information):

Additional context None

jakobkoerber commented 9 months ago

The information shown on the lecture detail page is provided by the TUMonline API and therefore not really a bug regarding Campus-Flutter. We could think of overwriting this locally, but this would also mean that we differ from information provided by TUMonline

alexanderstephan commented 9 months ago

In this case, this behavior should also occur in the other TUM Campus Apps, right?

jakobkoerber commented 9 months ago

I assume so, yes. Campus-Flutter doesn't manipulate the provided data :)

The issue was with the wbservicesbasic.veranstaltungenDetails endpoint which serves the wrong semester, in bugfix/lecture-details-semester this is now overwritten with the correct value from the wbservicesbasic.veranstaltungenEigene endpoint