search

TUM-Dev / eat-api

Simple static API for some (student) food places in Munich.
https://eat-api.tum.sexy
MIT License
21 stars 14 forks source link

German Dish fetching is broken #257

Closed Friendly-Banana closed 2 months ago

Friendly-Banana commented 3 months ago

The german detail pages are broken

ARRAY(0x55b990b4bb10)

resulting in empty API responses. The english version still works for some reason

CommanderStorm commented 3 months ago

Has been reported Upstream, I don't see a fix on our side until StuWerk IT fixes this

Lieber Herr Elsinga,

danke für den Hinweis. Wir gehen der Sache nach. Aktuell arbeiten wir an unserem Kennzeichnungssystem. Es kann also zu Störungen kommen. https://www.studierendenwerk-muenchen-oberbayern.de/mensa/speiseplan/speiseplan_421_-de.html#heute

Diese URL geht

Friendly-Banana commented 3 months ago

We could maybe parse the weekly menu from that URL 🤔

jakobkoerber commented 2 months ago

https://www.mensaplan.de/garching/mensa-garching/index.html

Interestingly enough this website has no issues displaying the meal plan whatsoever. Without any knowledge about the code base - is there anything we can do on our side? Would be great if we are up and running at the beginning of the new semester 🙂 thank you guys!

atticus-sullivan commented 2 months ago

Well I for my part, being impatient, started to crawl the current meal plan from the overview page which shows the meal plan of the whole month (not a particular day). Maybe that is what this website is doing (but of course I don't know the codebase either).

Friendly-Banana commented 2 months ago

This codebase currently crawls only the broken daily pages, it should be fairly easy to just point it at the monthly page and extract multiple days at once. @jakobkoerber if you're interested in contributing, StudentenwerkMenuParser would need to be changed.

jakobkoerber commented 2 months ago

I created a draft PR #263 that uses the overview page instead of the detail pages in the StudentenWerkMenuParser. Since I am not really familiar with Python nor have the capacity to adjust the tests since I'm also developing for the TCA, it would be great if someone could support me with the development 😄

Friendly-Banana commented 2 months ago

@jakobkoerber I've fixed the tests and linting issues in my fork.

jakobkoerber commented 2 months ago

@jakobkoerber I've fixed the tests and linting issues in my fork.

Nice, thank you! 😄

jakobkoerber commented 2 months ago

@Friendly-Banana only additional question I have: wouldn't we need to change the assets of the test? They look like the daily pages not the overview we are using now 🤔

Friendly-Banana commented 2 months ago

The test has both, the individual menu parsing with daily menus and the overview (src/test/assets/studentenwerk/mensa-garching/for-generation/overview.html)