search

TUW-GEO / ascat

Read and visualize data from the Advanced Scatterometer (ASCAT) on-board the series of Metop satellites
https://ascat.readthedocs.io/
MIT License
23 stars 16 forks source link

HSAF SMDAS SWI #43

Open wpreimes opened 3 years ago

wpreimes commented 3 years ago

Do you want to include the SMDAS data reader in this package? https://github.com/wpreimes/ascat/blob/smdas_reader/src/ascat/smdas.py

Then I'll fix some issues, clean up, write tests etc for it.

The data itself is a bit awkward, corrupt files, missing variables, deviating time stamps in metadata and filename etc. Therefore the reader is also a bit messy...

sebhahn commented 3 years ago

Which products do you mean by SMDAS exactly?

wpreimes commented 3 years ago

H-SAF SM-DAS-2 H-14 root zone soil moisture index product, based on ASCAT surface soil moisture data assimilation in the ECMWF Land Data Assimilation System

sebhahn commented 3 years ago

Yes it makes sense to add a reader, but sooner or later it this should be moved to its own package here https://github.com/H-SAF

sebhahn commented 3 years ago

Same for all other H SAF SM products

wpreimes commented 3 years ago

If you want I can make a new package for the SMDAS data now already. Just tell me what you prefer.

sebhahn commented 3 years ago

Probably it makes sense to start with a new package, but I wouldn't call it SMDAS.

However, first I need to think about how to structure the packages in H SAF (package per product, package per variable, ...). What would you prefer as a user?

sebhahn commented 3 years ago

@davidfairbairn do you have an opinion how to structure the python packages on H SAF?

wpreimes commented 3 years ago

From a user perspective it would be nice to have everything in one place. But from a developer point of view I think a package per product makes more sense than a package per variable, because of different file types, dependencies, resolutions etc. So maybe multiple smaller readers and one toolbox to collect them?

sebhahn commented 3 years ago

I like the idea with the toolbox, but typically products are quite similar in their format, type, etc. so probably a package per variable makes more sense? surface soil moisture and root zone soil moisture separated