Closed wpreimes closed 3 years ago
this includes #12 and #31
Some feedback I got:
at the following stations is 1 sensor that creates an error in the metadata generation: FLUXNET-AMERIFLUX\VairaRanch MONGOLIA\Khutag-under MONGOLIA\Murun OZNET\Uri-Park RISMA\CEF RISMA\MB10 RISMA\MB1 RISMA\MB11 RISMA\MB4 RISMA\MB2 RISMA\MB5 RISMA\MB6 RISMA\MB8 RISMA\ON4 RISMA\ON5 RISMA\SK1 RISMA\ON6 RISMA\SK2 RISMA\SK4 RUSWET-AGRO\Latvia RUSWET-AGRO\Oshskaya RUSWET-AGRO\SyrdarinskayaO SCAN\Vermillion SNOTEL\BILLIECREEKDIVIDE
I think the metadata issue is due to the csv files. and catching errors is what the reader should do and does in those cases. So this is open for merging again.
yes, good point, changed it.
Von: pstradio @.***> Gesendet: Dienstag, 16. März 2021 09:13 An: TUW-GEO/ismn Cc: Preimesberger, Wolfgang; Author Betreff: Re: [TUW-GEO/ismn] New package (#32)
@pstradio commented on this pull request.
In src/ismn/interface.pyhttps://github.com/TUW-GEO/ismn/pull/32#discussion_r594942333:
- def getitem(self, item):
- return self.collection[item]
- def repr(self):
- return f"{self.root}\n" \
- f"with Networks[Stations]:\n" \
- f"------------------------\n" \
- f"{self.collection.repr(' ')}"
- @property
- def networks(self):
- return self.collection.networks
- @property
- def grid(self):
- return self.networks.grid
Shouldn't this be self.collection.grid ?
- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TUW-GEO/ismn/pull/32#pullrequestreview-612950452, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF2HQH2PWRNWHDQQXHZGPGDTD4HLXANCNFSM4WVA2HLA.
@daberer thanks for merging, now I'd suggest you check everything again, docs and build. Then when you are happy with everying and everything is ready for a new release (which should be a new major version, i.e. 1.0
) you can try the release script:
https://github.com/TUW-GEO/ismn/blob/master/.github/workflows/release.yml
This will trigger when you draft a new release on github (right side releases on the overview page), but before that you have to change the owner name in https://github.com/TUW-GEO/ismn/blob/master/.github/workflows/release.yml#L14 from wpreimes
to TUW-GEO, and add the pypi token to the github actions secrets (unfortunately I dont have the rights to get a token from pypi)
Hi, so here is the version of the package that I have been working on for some time. It would be good to get feedback and/or to merge and release this
It's using @sebhahn's classes for stations, networks sensors etc. but also implements the
ISMN_Interface
as before (where metadata is stored and loaded, so that using the ismn data is still fast). This is not fully backward compatible, but I tried to make the new class as similar to the old one as possible, so that people can still use it as before.Here is a list of changes:
Examples on using it are in https://github.com/wpreimes/ismn/blob/master/docs/read_and_plot_ismn_data/interface.ipynb
Things that might dislike compared to the old package:
@daberer @Adeaem @sebhahn any feedback?
Let me know what you think we should change, this is probably not perfect yet, but especially the new metadata handling, relative paths and reading from zip I think is very much needed.