TUfast-TUD / TUfast_TUD

Browser Extension for higher productivity with TU Dresden IT-Services 🚀
https://www.tu-fast.de
GNU General Public License v3.0
38 stars 13 forks source link

CustomInput - warn option #108

Closed Noxdor closed 2 years ago

Noxdor commented 2 years ago

Description

This PR fixes the issue that there exist old or generally uncommon login names, whose setup right now is blocked by our regex on the input field. This PR fixes this by implementing a warn prop for the Input custom component that still marks the field as valid, even if the regex isn't fulfilled. The PR adjusts the style for warn Inputs to show the color themes warning color and uses the phosphor warning icon. It also adds the new prop to the uname input field in Onboarding and setting page.

image

References

Referenced Issue:

107 (Closed by this)

Type of change

Further info

Testing

We have 1500+ Users. Please test your changes thoroughly.

Additional Information

npm run test and npm run lint still error for me, is that for you guys @OliEfr @C0ntroller the case too?

ghost commented 2 years ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=108&src=https%3A%2F%2Fgithub.com%2FTUfast-TUD%2FTUfast_TUD)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend