This PR fixes the issue that there exist old or generally uncommon login names, whose setup right now is blocked by our regex on the input field. This PR fixes this by implementing a warn prop for the Input custom component that still marks the field as valid, even if the regex isn't fulfilled. The PR adjusts the style for warn Inputs to show the color themes warning color and uses the phosphor warning icon. It also adds the new prop to the uname input field in Onboarding and setting page.
References
Referenced Issue:
107 (Closed by this)
Type of change
[ ] Bug fix (non-breaking change which fixes a bug)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that might cause existing functionality to not work as expected)
Further info
[ ] This change requires a documentation update
[ ] I updated the documentation accordingly, if required
[x] I commented my code where its useful
Testing
We have 1500+ Users. Please test your changes thoroughly.
[ ] Tested my changes on Firefox
[x] Tested my changes on Chromium-Based-Browsers
[ ] Successfully run npm run test locally
Additional Information
npm run test and npm run lint still error for me, is that for you guys @OliEfr @C0ntroller the case too?
👇 Click on the image for a new way to code review
- Make big changes easier — review code in small groups of related files
- Know where to start — see the whole change at a glance
- Take a code tour — explore the change with an interactive tour
- Make comments and review — all fully sync’ed with github
[Try it now!](https://app.codesee.io/r/reviews?pr=108&src=https%3A%2F%2Fgithub.com%2FTUfast-TUD%2FTUfast_TUD)
Description
This PR fixes the issue that there exist old or generally uncommon login names, whose setup right now is blocked by our regex on the input field. This PR fixes this by implementing a
warn
prop for theInput
custom component that still marks the field as valid, even if the regex isn't fulfilled. The PR adjusts the style forwarn
Inputs to show the color themeswarning
color and uses the phosphor warning icon. It also adds the new prop to the uname input field in Onboarding and setting page.References
Referenced Issue:
107 (Closed by this)
Type of change
Further info
Testing
We have 1500+ Users. Please test your changes thoroughly.
npm run test
locallyAdditional Information
npm run test
andnpm run lint
still error for me, is that for you guys @OliEfr @C0ntroller the case too?