search

TUfast-TUD / TUfast_TUD

Browser Extension for higher productivity with TU Dresden IT-Services 🚀
https://www.tu-fast.de
GNU General Public License v3.0
39 stars 13 forks source link

[BUG]: Build instructions in CONTRIBUTING.md are imperfect #136

Closed Nix-da closed 10 months ago

Nix-da commented 10 months ago

What is the bug? Two commands in the building instructions are wrong:

Under the headline "Working in this repo" -> "steps to contribute" -> "5." is currently: Run npm useChrome or npm useFF to select the browser you are developing for - this will copy the corresponding manifest.json

but has to be: Run npm run useChrome or npm run useFF to select the browser you are developing for - this will copy the corresponding manifest.json

Also both scripts are not working on windows. This may also be worth a hint.

C0ntroller commented 10 months ago

Fixed by #132 Will be merged into main with next release.

OliEfr commented 10 months ago

What is the bug? Two commands in the building instructions are wrong:

Under the headline "Working in this repo" -> "steps to contribute" -> "5." is currently: Run npm useChrome or npm useFF to select the browser you are developing for - this will copy the corresponding manifest.json

but has to be: Run npm run useChrome or npm run useFF to select the browser you are developing for - this will copy the corresponding manifest.json

Also both scripts are not working on windows. This may also be worth a hint.

Thanks @Nix-da For being attentive and reporting anyway :)