search

TV-Rename / tvrename

Organise your TV & Movie videos with ease
http://www.tvrename.com
Other
299 stars 37 forks source link

Fresh install causes unsolicited reboot in Win 10 #725

Open mejico opened 4 years ago

mejico commented 4 years ago

When a fresh install of the app is carried out and .Net framework is installed as part of the install an unannounced (ie unsolicited) system reboot is carried out without warning, this is due to the switches used in the command line for the .net framework installer which is run by the TVrename installer.

SirSparkles commented 4 years ago

Any ideas what needs to be changed?

https://github.com/TV-Rename/tvrename/blob/master/Installer.nsi

mejico commented 4 years ago

Hi,

Thanks for the response. Not having written any scripts in over 2 decades (and even then I was rubbish) my guess is that it lies in the macro called by the installer:

!insertmacro CheckNetFramework 472

I did notice (as i had enabled ]show details’ during the install the one of the switches used in the .net framework install command line was ‘/q’ guessing that MS hasn’t changed their defaults for switch nomenclature I would assume the ‘/q’ means quiet mode hence avoid the need for user intervention. Without looking at all the available switches my guess (an I do mean guess) is by dropping the /q the user would be prompted for a reboot. I must admit I didn’t pay any attention to any of the other switches used, so for all I know there might have been a ‘/f’ if that even is available.

Sorry that I cant give more information, as I don’t remember the name of the executable used, so I couldn’t research all the switches.

Cheers, George

From: SirSparkles Sent: Thursday, May 21, 2020 1:48 AM To: TV-Rename/tvrename Cc: mejico ; Author Subject: Re: [TV-Rename/tvrename] Fresh install causes unsolicited reboot in Win 10 (#725)

Any ideas what needs to be changed?

https://github.com/TV-Rename/tvrename/blob/master/Installer.nsi

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

SirSparkles commented 4 years ago

Looks like we may need to udpate to another script source. Eg https://github.com/tbnorris/NsisDotNetChecker from https://github.com/ReVolly/NsisDotNetChecker

but my scripting is not strong enough to know what to do with the return code this new script returns

mejico commented 4 years ago

Given my limited knowledge and understanding you only need to run this macro:

!insertmacro CheckNetFrameworkDelayRestart 472 $0Which will use the /norestart switch with the installer causing it to install without reboot. Then my guess would be that you would then need to include a reboot prompt in your installer to ensure .net 472 is fully functional.

My background is IT operations with very little development thrown in, so my understanding lacks any coding training.

I hope this helps.

Cheers, George

From: SirSparkles Sent: Thursday, May 21, 2020 11:54 PM To: TV-Rename/tvrename Cc: mejico ; Author Subject: Re: [TV-Rename/tvrename] Fresh install causes unsolicited reboot in Win 10 (#725)

Looks like we may need to udpate to another script source. Eg https://github.com/tbnorris/NsisDotNetChecker from https://github.com/ReVolly/NsisDotNetChecker

but my scripting is not strong enough to know what to do with the return code this new script returns

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.