search

TWCable / puppet-adobe_em6

A Puppet module for installation and configuration management of Adobe Experience Manager 6.x
4 stars 8 forks source link

TWCable-20582 mod_pagespeed puppet install #15

Closed brianliddle closed 8 years ago

brianliddle commented 8 years ago

@GaryHowell @jdigger @fortman @cculb @KyleBaker @BrianArmstrong - Not ready for testing, but definitely would appreciate collaborative comments on this one. Essentially, I'm trying to leverage the existing structure to install mod_pagespeed. One assumption is that the dispatcher is already installed. Once we can leverage this code, we'll add a verify step to make sure that it's installed and running.

wobes commented 8 years ago

We should talk about this. interesting that it is being added to the adobe_em6 module rather then adobe_dispatcher6 module.

Adding @jbornemann

wobes commented 8 years ago

using execs and system calls is not the best approach here. should be leveraging a repo to install rpm not curls. Also should be using the puppet service framework and not making "sudo" system calls.

jbornemann commented 8 years ago

I agree, I don't think this is the change we need. We should discuss internally. The AEM module should only be provisioning AEM. The dispatcher module should only be provisioning the dispatcher.

jdigger commented 8 years ago

Can I close this PR?

fortman commented 8 years ago

@jdigger Yes, please close this.