TWEagle / galleriffic

Automatically exported from code.google.com/p/galleriffic
0 stars 0 forks source link

Top pager div is always rendered #37

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Disable top pager (enableTopPager: false)
2. See generated gallery html and notice an empty <div class="top
pagination"></div>

What is the expected output? What do you see instead?
The empty <div> should not be rendered, as is the bottom pager behaviour
when disabled.

What version of the product are you using? On what operating system?
Galleriffic 1.0. Firefox 3.5.3. Windows XP.

Please provide any additional information below.
I suggest the following code, analog to the bottom page rendering code:

                // Rebuild top pager
                if (needsPagination && this.settings.enableTopPager) {
                    var $topPager = this.$thumbsContainer.find('div.top');
                    if ($topPager.length == 0)
                        $topPager = this.$thumbsContainer.prepend('<div class="top
pagination"></div>').find('div.top');
                    else
                        $topPager.empty();
                    this.buildPager($topPager);
                }

Original issue reported on code.google.com by ericniel...@gmail.com on 22 Sep 2009 at 2:57

GoogleCodeExporter commented 9 years ago
Ok. This is fixed in 2.0 release. Thanks!

Original comment by ericniel...@gmail.com on 9 Nov 2009 at 10:38