TWJolly / fundraising_data_pull

Pulls data from the JustGiving API for a defined set of charities and highlights new pages
1 stars 1 forks source link

export rds too #13

Closed daaronr closed 6 years ago

daaronr commented 6 years ago

minor update

TWJolly commented 6 years ago

@daaronr I've not saved rds files before - what is the advantage?

There's a load statement that uses an absolute path from your PC in .Rapp.history in this pull. Not sure what is happening there - do you know?

daaronr commented 6 years ago

@daaronr I've not saved rds files before - what is the advantage?

Rds: I was thinking about preserving the data structures (factor formats etc). Also putting the csv files together didn't work for me at first but I guess that's fixed now.

There's a load statement that uses an absolute path from your PC in .Rapp.history in this pull. Not sure what is happening there - do you know?

That should be removed I think.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

daaronr commented 6 years ago

@TWJolly I was having some trouble with the files created from putting the csv's together in combine_available_data.R containing a lot of strange stuff (that work is on Dropbox, although maybe it's easier to collaborate if we move it to Github?). I had thought the error might have come from issues with bringing it in and out of csv format. Rds ("write_rds") would seem to be the way of saving in native R format, preserving data structures, column names, features etc.

However, it looks like we don't really do anything in terms of defining data structures in the Fundraising_data_pull files anyways, so maybe it doesn't matter?