Closed kashefy closed 7 years ago
Looking good. Two suggestions: 1) put execute into the superclass as well, they all have shared code. Create an amlttpExecute method that gets called from within execute 2) in the IdLocKs, notify should be called at the end outside of the loop, i.e. only once. -- actually the notify is one of the lines that could get into the super.execute().
What do you think?
challenge accepted
Feedback incorporated.
IdentityLocationKS
Very good. Thank you
new
AbstractAMLTTP
parent class for KSs that are driven by AMLTTP models (e.g.IdentityKS
,SegmentIdentityKS
,NumberOfSourcesKS
,IdentityLocationKS
) The parent class takes care of reading the model input file and checking its content (featureCreator',
blockCreator'). Derived classes implement the excute method and can override these checks.This resolves #32 and is a followup to the discussion in #30