search

TWiStErRob / net.twisterrob.ghlint

https://ghlint.twisterrob.net/
7 stars 1 forks source link

Step ID is not unique #209

Open TWiStErRob opened 1 month ago

TWiStErRob commented 1 month ago

Version

0.3.1

Reproduction steps

  1. File .github/workflows/x.yml with the following content:

    on: push
jobs:
 repro:
   runs-on: ubuntu-latest
   steps:
     - uses: actions/github-script@v7
       with:
         script: |
           const title = "${'$'}{{ github.event.pull_request.title }}";
           return title;
     - uses: actions/github-script@v7
       with:
         script: |
           const title = "${'$'}{{ github.event.pull_request.title }}";
           return title;

  2. Run ghlint with the following arguments:

    ghlint --console .github/workflows/x.yml

Expected behavior

Ability to distinguish which step is targeted.

Actual behavior

Step[actions/github-script@v7] in Job[test] JavaScript contains GitHub Expressions.
Step[actions/github-script@v7] in Job[test] JavaScript contains GitHub Expressions.

Additional Context

See TODO re-think identifier, there could be multiple like this, it's not unique in code.