TWiStErRob / renovate-config

Configuration files for renovatebot installed in repositories
https://docs.renovatebot.com/config-presets/#organization-level-presets
The Unlicense
4 stars 0 forks source link

INFO: Use matchDepNames instead of matchPackageNames #23

Closed TWiStErRob closed 4 months ago

TWiStErRob commented 7 months ago

To find all affected repositories:

https://github.com/search?q=org%3ATWiStErRob+%22Use+matchDepNames+instead+of+matchPackageNames%22&type=issues

TWiStErRob commented 5 months ago

It is now a warning image

image

TWiStErRob commented 4 months ago

https://github.com/search?q=org%3ATWiStErRob+matchPackageNames+-is%3Afork&type=code shows 15 files.

Looking at the logs more explicitly, fixing one might fix most of the warnings:

DEBUG: Looking up com.gradle.develocity:com.gradle.develocity.gradle.plugin in repository https://dl.google.com/android/maven2/
WARN: Use matchDepNames instead of matchPackageNames
{
  "packageRule": {
    "description": [
      "Auto-merge all updates of specific dependencies, their 0.x versions are stable and well-controlled."
    ],
    "matchUpdateTypes": [
      "minor",
      "patch"
    ],
    "matchCurrentVersion": "/^0/",
    "matchPackageNames": [
      "org.gradle.toolchains.foojay-resolver-convention"
    ],
    "automerge": true
  }
  "packageName": "org.gradle.toolchains.foojay-resolver-convention:org.gradle.toolchains.foojay-resolver-convention.gradle.plugin"
  "depName": "org.gradle.toolchains.foojay-resolver-convention"
}

DEBUG: Looking up org.gradle.toolchains.foojay-resolver-convention:org.gradle.toolchains.foojay-resolver-convention.gradle.plugin in repository https://dl.google.com/android/maven2/

Notice that depName and packageName are significantly different, so need to review EVERY change separately.

TWiStErRob commented 4 months ago

Rules seem to be:

Note: this means changing Gradle Plugins to matchDepNames is not the solution, fix the pattern instead to match on the Marker artifact, because that will give higher coverage for the rule (e.g. toml [libraries] block or buildSrc explicit dependency.

TWiStErRob commented 4 months ago

In inventory this also warns:

WARN: Use matchDepNames instead of matchPackageNames
{
  "packageRule": {
    "groupName": "Android Gradle Plugin",
    "description": [
      "Group together all dependencies and plugin aliases from AGP."
    ],
    "matchPackageNames": [
      "com.android.tools.build:gradle",
      "android",
      "com.android.application",
      "com.android.asset-pack",
      "com.android.asset-pack-bundle",
      "com.android.base",
      "com.android.dynamic-feature",
      "com.android.fused-library",
      "com.android.internal.application",
      "com.android.internal.asset-pack",
      "com.android.internal.asset-pack-bundle",
      "com.android.internal.dynamic-feature",
      "com.android.internal.fused-library",
      "com.android.internal.library",
      "com.android.internal.reporting",
      "com.android.internal.test",
      "com.android.internal.version-check",
      "android-library",
      "com.android.library",
      "com.android.lint",
      "android-reporting",
      "com.android.reporting",
      "com.android.test"
    ],
    "separateMajorMinor": true,
    "separateMultipleMajor": true,
    "separateMinorPatch": true
  }
  "packageName": "com.android.application:com.android.application.gradle.plugin"
  "depName": "com.android.application"
}