TX-2 / TX-2-simulator

Simulator for the pioneering TX-2 computer
https://tx-2.github.io/
MIT License
21 stars 2 forks source link

Move main loop out of cpu crate (#35) #36

Closed ghost closed 2 years ago

ghost commented 2 years ago

this commit fixes/closes #35 moved run_until_alarm function from (cpu/src/lib.rs) to (cpu/src/lib.rs)

jamesyoungman commented 2 years ago

Thank you for your contribution. I'm thrilled that you sent this. Thank you.

Unfortunately I made this change myself, before I saw your PR. That's on me, it's kind of stupid to mark something as a "good first issue" and then just close it myself. Can't be an ideal experience for you; sorry!

But I'd like to encourage you to contribute in other ways, and now that I know you're interested, I can take more care not to get in your way.

jamesyoungman commented 2 years ago

I rebased your PR and merged it.