search

TYPO3-CMS / styleguide

[READ-ONLY] Subtree split of the TYPO3 Core Extension "styleguide"
GNU General Public License v2.0
101 stars 62 forks source link

Some text inside example code is unreadable with dark mode active #411

Closed PKuhlmay closed 8 months ago

PKuhlmay commented 1 year ago

Bug Report

Prerequisites

Description

When I have dark mode inside my Mac active, some text inside the example code is not readable. The text is white in front of lightgray background.

When having the light mode active, it works.

Steps to Reproduce

  1. Set dark mode inside the Mac OS settings
  2. Open the styleguide module and then open (for example) the accordion

Expected behavior: The text should be black, not white.

Actual behavior: The text is white, not black.

Versions

TYPO3 12.4.2 Styleguide dev-main composer, ddev Bildschirmfoto 2023-07-04 um 12 05 18

lolli42 commented 8 months ago

We removed prism.js in styleguide-main. This should only be a issue with v12 now.

lolli42 commented 8 months ago

Hey. With this being "fixed" in current styleguide main, I'll close here for now. Styleguide v12 is only loosely maintained by us, we'd probably not fix this on our own, except anyone comes up with a PR. We can re-open or create a new issue in case this is picked up.