search

TYPO3-Caretaker / caretaker

TYPO3 extension caretaker
https://extensions.typo3.org/extension/caretaker/
26 stars 24 forks source link

Override test configuration in BE does not work with FormEngine (7.5+) #39

Closed thommyhh closed 8 years ago

thommyhh commented 8 years ago

Due to the switch from TCEforms to FormEngine (since 7.5) the hook, that rendered the test configuration override and curl option items does not work anymore. I tried to make it work, but it wouldn't because of the flex form field of the "test configuration" inside the flex form section of test configurations (recursive flex form).

I asked on the Slack core dev channel: Christian Kuhn said, recursive flex form are not supported.

My idea is to migrate the flex form sections to inline records (tx_caretaker_instance_testconfiguration_override, tx_caretaker_instance_curl_option) in two separate fields. I would add a command controller to migrate the flex form sections to inline records and add an option in the extension configuration to enable the new mechanism (before 7.5, enabled automatically for 7.5 and later). This would use the given TYPO3 APIs and does not require any hooks.

I could work on this topic but I need your opinion. What to you think about the idea?

thomashempel commented 8 years ago

I would prefer to have only one type of "override". Overriding curl options and test settings are basically the same, aren't they?

thommyhh commented 8 years ago

Ok, I'll give it a try.

etobi commented 8 years ago

@thommyhh this is solved by your PR #38, right?