TYPO3-Documentation / T3DocTeam

This repository is for the Documentation Team. To contribute, please see CONTRIBUTING.md For help and support on TYPO3, please see: https://typo3.org/help/
3 stars 1 forks source link

TYPO3: Turn SVG icons into sprite #178

Closed marble closed 10 months ago

marble commented 2 years ago

See Slack discussion

The TYPO3 GmbH has provided a bunch of SVG icons

Thank you very much for that. @tomwarwick has uploaded them to a branch of our homepage repository: https://github.com/TYPO3-Documentation/DocsTypo3Org-Homepage/tree/add-icons-homepage-cards/Documentation/Icons

Turn SVG icons into icon font!?

Usually that's the way sets of icons are handled and used, like the fort-awesome package we are using.

See also

Format recommendations:

About sprites

linawolf commented 2 years ago

It was decided to use a sprite.

So I have to rephrase my question a bit: Has anybody combined those SVG already in a all-the-icons-combined-sprite.svgfile? Who would volunteer to do that? And create an html demo page showing them. Help wanted with this! Especially if you are a FRONTEND GUY please consider volunteering.

marble commented 2 years ago

from Slack, Alex:

have you checked https://github.com/TYPO3/TYPO3.Icons already? it is about the TYPO3 CMS icons and also considering sprites besides some other output styles, and pushing it to GitHub as well as to NPM for inclusion. would align the generation and deployment of your icon set to it as much as possible.

this seems to be the gulp task that is creating the sprite: https://github.com/TYPO3/TYPO3.Icons/blob/main/gulpfile.js#L287

linawolf commented 10 months ago

I think we will not turn them into a sprite. These svgs will only be loaded in few places so it is not worth the trouble