TYPO3-Documentation / TYPO3CMS-Reference-ViewHelper

Automatically generated ViewHelper reference
https://docs.typo3.org/other/typo3/view-helper-reference/master/en-us/
0 stars 17 forks source link

[DOCS] Provide segment about Header/FooterAssets #39

Closed helsner closed 2 years ago

DavidBruchmann commented 3 years ago

Great, what you think about some example code?

helsner commented 3 years ago

I could provide that if you want to, but i could not really see the big advantage of that IMHO as the info is pretty straight forward. Maybe for visual separation reasons But i would add that on your call!

DavidBruchmann commented 3 years ago

The info in the Changelog is more extensive than your description (also including the option to override renderAssetsForRequest). So it would be good if the same info is at least available - this can be copy & paste fully or partially, that's no problem.
An example would be nice I think, but it could be rudimentarily, just to show the general usage.

DavidBruchmann commented 3 years ago

@helsner I hope the backticks render it correctly, in the preview above it seems being wrong. And I hope you don't mind about my edits ;-)

helsner commented 3 years ago

Looks good to me! I mind the edits, as they mean i could've done better 😝 Thanks for your help and exchange on this topic

DavidBruchmann commented 3 years ago

@helsner you found it and cared about it, that's most important ;-)

DavidBruchmann commented 3 years ago

Ohh, I'm sorry. I fear that was somehow my fault.

linawolf commented 3 years ago

@helsner I fear susannemoog is right. Unfortunarely you wouldhave to move this to the source code.

I put your PR on draft so none merges it accidently.

helsner commented 3 years ago

Hi y'all - could you help me out where i find the correct source? just checked the core without success 😬

susannemoog commented 3 years ago

@helsner sure: https://github.com/TYPO3/Fluid/blob/master/src/ViewHelpers/SectionViewHelper.php#L17 - the hint to find it is the package name in the file path (typo3fluid/fluid === TYPO3/Fluid, so the main fluid repository)

helsner commented 3 years ago

Thx for the hint - then i was right already.. i wasn't sure. https://github.com/TYPO3/Fluid/pull/558

linawolf commented 2 years ago

was solved with https://github.com/TYPO3/Fluid/pull/558