search

TYPO3-Documentation / sphinx_typo3_theme

Sphinx theme for docs.typo3.org
https://typo3-documentation.github.io/sphinx_typo3_theme
MIT License
28 stars 18 forks source link

Styling of confval directive #170

Closed linawolf closed 2 years ago

linawolf commented 2 years ago

With the new theme the confval directive gets rendered like this:

NewsConfval

While I like the new form and tab-like apppearance there are some drawbacks:

The red text on the brownish background is not accessible enough: https://contrast-ratio.com/#%23c02-on-%23ECDCC6, it only has a contrast ratio of 4.35.

The background color is not used in other places. The red of the text feels like a warning and doesn't really go along with our TYPO3 orange.

Also as we are talking about configuration values I would like to keep the code-like monospaced font. I would suggest to style the confvals like this:

Idee1

The text of the confval theme would have a contrast of over 18 then and is easy to read: https://contrast-ratio.com/#%23000-on-%23e8e8e8 and the colors appear elsewhere on the site.

Before the update the confval looked like this:

image

The contrast ratio of 2,83 https://contrast-ratio.com/#%23ff5370-on-%23EBF7FB was even worse for the color blind and we had the problem of colours that appear nowhere else.

If you agree, Martin I can provide a PR for this.

marble commented 2 years ago

Fixed in sphinx_typo3_theme >=4.7.6.dev3+gb8ca847, scheduled for DRC >= v3.0.dev27