TYPO3-Documentation / sphinx_typo3_theme

Sphinx theme for docs.typo3.org
https://typo3-documentation.github.io/sphinx_typo3_theme
MIT License
28 stars 18 forks source link

Copying code snippets will include line numbers #184

Closed fnagel closed 1 year ago

fnagel commented 1 year ago

I've noticed its not possible to copy code snippets without copying the line numbers? Is this an EXT:news issue or a general one?

https://docs.typo3.org/p/georgringer/news/10.0/en-us/Tutorials/BestPractice/Routing/Index.html#id3

Reference: https://typo3.slack.com/archives/C028JEPJL/p1676383069691979

sypets commented 1 year ago

Same on official documentation pages.

marble commented 1 year ago

Related to #149

DavidBruchmann commented 1 year ago

related to #207, here it's more specific though as it's related to sphinx.

marble commented 1 year ago

Fixed with TYPO3 Theme 4.7.10 which is used in DRC v3.0.0

fnagel commented 1 year ago

Sorry for the late response. Vacation and the aftermath of it caused a delay ;-)

Afaics this is still an issue, at least for older EXT:news docs, see https://docs.typo3.org/p/georgringer/news/11.0/en-us/Tutorials/BestPractice/Routing/Index.html

It works as expected in newer and latest version:

Not sure if it was only possible to fix this for newer releases. Just wanted to give you some feedback.

FYI @marble

brotkrueml commented 1 year ago

The manuals of older versions have to be re-rendered (not only EXT:news, but also all other extension which are available of docs.typo3.org). As this is not feasible we have to live with that.

fnagel commented 1 year ago

@brotkrueml Ok, thanks for letting me know!

marble commented 1 year ago

@fnagel No, we don't have to live with it. Meanwhile I've triggered a re-rendering at https://intercept.typo3.com/admin/docs/deployments?docs_deployment_filter%5Bsearch%5D=georgringer/news&docs_deployment_filter%5Btype%5D=&docs_deployment_filter%5Bstatus%5D=&docs_deployment_filter%5Btrigger%5D=&docs_deployment_filter%5B_token%5D=aaed05b17d4094835ab9b714b4c5.W3J4Ech390lpgavBLlHomb3Un85F2tuh4ibIGyJjAzo.KRkUV6ohhnoh0Zu1eROpxuKl66QqnY_P0nWXNmMsbVtoFQ5g8TXDBCO05g&page=1 for most of the versions I found. They should soon be up to date and work as expected.

brotkrueml commented 1 year ago

Yes, but this only is for EXT:news, not for all the other extension manuals out there, which have the line numbers in the clipboard when copying. This is what I meant.

marble commented 1 year ago

Well, we could make a script that uses the information from intercept and, one by one, triggers a rerendering of all manuals that aren't up to date. At least this should be possible for all manuals that have a successful rendering. It would be possible for more manuals as well. I would love to care about this. However, I haven't been able to establish a respectful cooperation with the GmbH for this in any way. Susi would be able to re-render everything. Something that Andreas simply denies. And he refuses to be helpful. For the records: Back then, the GmbH insisted on taking over the hosting part and promised, it would always be possible, to tell Intercept to re-render everything that has been rendered before.

brotkrueml commented 1 year ago

It is worth the resources? Just for old and outdated manuals? Clearly we can do it. We should then also think about when to re-render all manuals for all versions (from the docs team and 3rd-party extensions) for future changes. IMHO it is a waste of time and resources for outdated versions and manuals. But feel free to care about it and proceed.