Thought collection

[liayn]

Just a collection of some thoughts:

• Instead of returning the generated image as a response, better redirect to itself, so the second request is answered by the webserver with the rendered image => all headers are as they should be or as configured by the webserver and nothing needs to be mimicked by PHP.
• I would remove all unit tests which simply test a getter that returns the value straight, that has no real value
• Hardcoded serialized data in tests are rather cumbersome to maintain, consider doing the serialization during runtime maybe or create the mock data differently
• The .htaccess rules need documentation that those need to match the file extensions for image_ext and/or media_ext
• What about previews for pdf/ai/etc?
• Maybe the queue can use the queue implementation of the core? (not sure if this is possible, just an idea)

[s2b]

Instead of returning the generated image as a response, better redirect to itself, so the second request is answered by the webserver with the rendered image => all headers are as they should be or as configured by the webserver and nothing needs to be mimicked by PHP.

I would agree with that. That makes the implementation much easier.

[IndyIndyIndy]

Also, a way to still prioritize (directly render in the same request) some images could be really useful. For instance for a bunch of "above the fold" images or the "first x" images in a gallery. Like a "preprocess" attribute in all image viewhelpers.

This extension is already very similar to the ideas I was about to implement and try out for some projects, so maybe I could test and contribute a bit.