TYPO3-Headless / headless

TYPO3 Headless JSON API providing content for PWA application (e.g. javaScript apps like nuxt-typo3)
https://t3headless.io
GNU General Public License v2.0
159 stars 60 forks source link

[BUGFIX] Correct `linkText` value in headerLink property #667

Closed schloram closed 11 months ago

schloram commented 11 months ago

Due to the additional option field = header_link setting the output of linkText value was always something like t3://page?uid=13 for internal links. But it would be better to let typolink always handle the linkText to have it replaced with e.g the page title.

Current:

"headerLink": {
  "href": "/my-page",
  "target": null,
  "class": null,
  "title": null,
  "linkText": "t3://page?uid=13",
  "additionalAttributes": []
}

Fixed:

"headerLink": {
  "href": "/my-page",
  "target": null,
  "class": null,
  "title": null,
  "linkText": "My Page",
  "additionalAttributes": []
}
coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 6785483387


Totals Coverage Status
Change from base Build 6772803664: 0.0%
Covered Lines: 822
Relevant Lines: 1298

💛 - Coveralls
lukaszuznanski commented 11 months ago

@schloram thanks for this PR, I'm merging it into master, could you also provide one for version 3.x? You need to create new branch out of 3.x and create PR to 3.x.

Thanks!

schloram commented 11 months ago

@lukaszuznanski Done. -> https://github.com/TYPO3-Headless/headless/pull/673