[BUGFIX] Fix endless loop for CType menu_section

TYPO3-Headless / headless

TYPO3 Headless JSON API providing content for PWA application (e.g. javaScript apps like nuxt-typo3)

https://t3headless.io

GNU General Public License v2.0

159 stars 60 forks source link

[BUGFIX] Fix endless loop for CType menu_section #716

Closed kitzberger closed 5 months ago

kitzberger commented 6 months ago

In case the CE menu_section itself is with sectionIndex=1 we run into an endless loop when using the default tt_content rendering instructions to render the menu items.

Resolves: #715

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8696822942

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.411%

Totals
Change from base Build 8571035354:	0.0%
Covered Lines:	847
Relevant Lines:	1315

💛 - Coveralls

lukaszuznanski commented 5 months ago

@kitzberger can you confirm that latest changes on main fixed this issue? Let me know so we can proceed with this PR or close it

kitzberger commented 5 months ago

@kitzberger can you confirm that latest changes on main fixed this issue? Let me know so we can proceed with this PR or close it

which commit exactly?

lukaszuznanski commented 5 months ago

@kitzberger https://github.com/TYPO3-Headless/headless/commit/8d4a2b35785c42cde786837111f94de9522400ab

lukaszuznanski commented 5 months ago

@kitzberger please let me know when you check it, so we can proceed

kitzberger commented 5 months ago

@lukaszuznanski, 882cec8 does solve the problem describe here! Thanks ;-)

I'm closing this PR now.