TYPO3-Headless / headless

TYPO3 Headless JSON API providing content for PWA application (e.g. javaScript apps like nuxt-typo3)
https://t3headless.io
GNU General Public License v2.0
156 stars 57 forks source link

[FEATURE] Improve file processing #724

Closed twoldanski closed 4 months ago

twoldanski commented 4 months ago

Resolves: #247, #617

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9033524206

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/Utility/FileUtility.php 133 143 93.01%
<!-- Total: 136 146 93.15% -->
Totals Coverage Status
Change from base Build 9032111423: 1.9%
Covered Lines: 949
Relevant Lines: 1439

💛 - Coveralls
kitzberger commented 4 months ago

@twoldanski, works like a charm, thanks!

develth commented 1 day ago

@twoldanski @lukaszuznanski how we should proceed here? reimplement the fileExtension only? What was the reason that it got removed?

twoldanski commented 1 day ago

@develth can create new issue? It was not removed, it should be applied. You have issue with 4.3.2?

Also please provide example typoscript you are using.

develth commented 1 day ago

It was not removed, it should be applied.

@twoldanski from the marked line, the fileExtension is removed. Do not see any part where it should get applied before fetchin a already processed media?

Also please provide example typoscript you are using.

Yes, had issues until i braught back fileExtension in my overridden GalleryProcessor

develth commented 1 day ago

Created an Issue: https://github.com/TYPO3-Headless/headless/issues/768