search

TYPO3-Headless / headless

TYPO3 Headless JSON API providing content for PWA application (e.g. javaScript apps like nuxt-typo3)
https://t3headless.io
GNU General Public License v2.0
160 stars 61 forks source link

Images get reprocessed on every request #768

Closed develth closed 2 months ago

develth commented 2 months ago

Describe the bug Images that get processed by GalleryProccesor get processed on every request, because hash is different caused by missing fileExtension

To Reproduce Steps to reproduce the behavior:

  1. Create Gallery
  2. Put Images in it
  3. See how Images get processed every time via xdebug or the processed image table

Expected behavior Images should be reused, cache should be equal before & after process

TYPO3 version and TYPO3 Headless version latest TYPO3 & Headless

Additional context Issue caused by removal of FileExtension before processing (see here )

The FileExtension is not included in Options anymore, but the Repository saves the processed file including the fileExtension, so Hash is always different. Hash Check in ProcessedFileRepository - debugger could set here to compare hashes on search & on persist

twoldanski commented 2 months ago

@develth thx for issue. Can you reproduce issue on dev-master ?

twoldanski commented 2 months ago

Hi @develth did you have a chance to verify if issue is reproducible on your end on dev-master branch ?

develth commented 2 months ago

@twoldanski sorry, no time until now. just checked out 4.4.0 & it seems to be fixed. thanks!