TYPO3-Headless / headless_news

Adds support for EXT:news to EXT:headless
MIT License
11 stars 18 forks source link

[BUGFIX] #24 Fix issue with news list view not rendering #25

Closed sivaprasad1988 closed 6 months ago

sivaprasad1988 commented 1 year ago

Tasks:

To-Do's:

Resolves: ##24

KrohnMi commented 1 year ago

@sivaprasad1988 With this implementation you remove all the information of the content element, like appearance etc. Or you also change the templates.

sivaprasad1988 commented 1 year ago

@KrohnMi I changed the template and added the following snippet in my fluid template. In this way, I will receive all my content element-related information.

"contentElementInfo":
  <f:format.raw>
      <f:format.json value="{
              0: contentObjectData
          }"/>
  </f:format.raw>,

Output https://www.screencast.com/t/lonwhzWoE

tlueder commented 1 year ago

Sure, but that removes the option to use the same configuration as for the other elements and one has to change the templates. Which is not ideal.

And also, why haven't you added this change to the templates here in your MR? In this from your MR produces semi broken JSON.

sivaprasad1988 commented 1 year ago

@tlueder Many thanks for the feedback. After having a closer look, I realize my mistake. Many thanks for the pointer. I corrected the TS a bit so that information on the content element, like appearance, etc., can be used with JSON results.

JSON Result https://www.screencast.com/t/CnG5emxav6HY

juliasaurin commented 1 year ago

@sivaprasad1988 Thanks for the Fix. It works now!!

lukaszuznanski commented 11 months ago

Is this still viable as new changes are merged into master?

sivaprasad1988 commented 11 months ago

If this is merged into master, I believe we could close this @lukaszuznanski

lukaszuznanski commented 6 months ago

Closing as resolved.