[BUG] DateRange Facet Datepicker doesn't display in other languages

[linawolf]

Describe the bug The Daterange datepicker is always displayed in English.

Importing the language package for the datepicker i.e.

page.includeJSFooterlibs {
    solr-ui-de = EXT:solr/Resources/Public/JavaScript/JQuery/ui-i18n/jquery.ui.datepicker-de.js
}

makes no difference

To Reproduce TYPO3 8.7.36 eLTS Extension solr 8.1.2

DataRange Facet with Standard Template, Typoscript:

plugin.tx_solr.search {
    #[....]

    faceting = 1
    faceting {
        facets = 1
        facets {
            allDatesRange {
                label = Zeitraum
                field = allDates_dateM

                type = dateRange

                dateRange {
                    start = NOW/DAY-1YEAR
                    end = NOW/DAY+1YEAR
                    gap = +1DAY
                }
            }
        }
    }
}

# Load js files
page.includeJSFooterlibs {
    solr-jquery = EXT:solr/Resources/Public/JavaScript/JQuery/jquery.min.js
    solr-ui = EXT:solr/Resources/Public/JavaScript/JQuery/jquery-ui.min.js
    solr-daterange = EXT:solr/Resources/Public/JavaScript/facet_daterange_controller.js
    solr-options = EXT:solr/Resources/Public/JavaScript/facet_options_controller.js
    solr-ui-de = EXT:solr/Resources/Public/JavaScript/JQuery/ui-i18n/jquery.ui.datepicker-de.js
}

page.includeCSS {
    solr-ui = EXT:solr/Resources/Css/JQueryUi/jquery-ui.custom.css
}

Expected behavior Month and Day should be in German

Used versions (please complete the following information):

• TYPO3 Version: 8.7.36 eLTS
• Browser: chrome
• EXT:solr Version: 8.1.2
• Used Apache Solr Version: solr-spec 8.2.0 solr-impl 8.2.0 31d7ec7bbfdcd2c4cc61d9d35e962165410b65fe - ivera - 2019-07-19 15:11:04 lucene-spec 8.2.0 lucene-impl 8.2.0 31d7ec7bbfdcd2c4cc61d9d35e962165410b65fe - ivera - 2019-07-19 15:05:56
• PHP Version: 7.2
• MySQL Version: [e.g. 5.6.0]

Additional context We have the same problem on several instances the only solution so far was to exchange the DateRange Picker for one Based on Bootstraps bootstrap-datepicker.min.js with our own Template. The error can be reproduced in ddev and on production server.

[dkd-kaehm]

Hello @linawolf, thanks for reporting. Isn't the jQuery Date Picker today not obsolete? What about browsers native date picker with some up-to-tode fallback js lib?

[linawolf]

I think it would be a good idea to ship a browsers native solution as working example. Such solutions are not trivial to implement.

web/typo3conf/ext/solr/Classes/Domain/Search/ResultSet/Facets/RangeBased/DateRange/DateRange.php

 protected function getRangeString()
    {
        return $this->startRequested->format('Ymd') . '0000-' . $this->endRequested->format('Ymd') . '0000';
    }

Throws error if start or enddate is not set. So we hat to do some JS tweaks to never send an empty date.