[BUG] PHP Warning: Argument 1 passed to SchemaParser::parseJson() must be of the type string, null given

[SSFGizmo]

(1/1) TypeError

Argument 1 passed to ApacheSolrForTypo3\Solr\System\Solr\Parser\SchemaParser::parseJson() must be of the type string, null given,
called in /solr/Classes/System/Solr/Service/SolrAdminService.php on line 274

To Reproduce Steps to reproduce the behavior:

• Container is offline
• Select page with site configuration
• Click on 'Core Optimization'

Used versions (please complete the following information):

• TYPO3 Version: 11.5.18
• EXT:solr Version: 6939e2a92aca2c32ea5083c32d717123d18ae9ec
• PHP Version: 7.4.30

[dkd-kaehm]

@SSFGizmo Thanks for the reporting this issue.

Why you are not using the GitHub-Issue template as is? https://github.com/TYPO3-Solr/ext-solr/issues/new?assignees=&labels=&template=bug_report.md&title=%5BBUG%5D+Please+add+a+speaking+title

With "Container is offline" and "Click on 'Core Optimization'", you mean the steps to reproduce?

[SSFGizmo]

@dkd-kaehm Sorry, I removed too many lines from this template.

With "Container is offline" and "Click on 'Core Optimization'", you mean the steps to reproduce?

yes

[SSFGizmo]

maybe it's enough to add

?? ''

/solr/Classes/System/Solr/Service/SolrAdminService.php

public function getSchema(): Schema
...
   $this->schema = $this->schemaParser->parseJson($response->getRawResponse() ?? '');

public function getSynonyms(string $baseWord = ''): array
...
   return $this->synonymParser->parseJson($baseWord, $response->getRawResponse() ?? '');

public function getStopWords(): array
...
    return $this->stopWordParser->parseJson($response->getRawResponse() ?? '');

[dkd-kaehm]

IMHO, The right exception should be thrown before that all kicks in. The $response must be valid.

@dkd-friedrich did a Changes to exceptions handling. It would be nice to handle those troubles in proper way as well.

[dkd-friedrich]

The right exception should be thrown before that all kicks in.

I agree, we should handle the cause of this issues.

@dkd-friedrich did a Changes to exceptions handling. It would be nice to handle those troubles in proper way as well.

Extensions are unfortunately not yet complete and contain breaking changes in the current form.

The plan is to use more specific exceptions, which are based on an EXT:solr base exception. I will try to provide the base exception soon, so we can use this here.

[SSFGizmo]

thx