search

TYPO3-Solr / ext-solr

A TYPO3 extension that integrates the Apache Solr search server with TYPO3 CMS. dkd Internet Service GmbH is developing the extension. Community contributions are welcome. See CONTRIBUTING.md for details.
GNU General Public License v3.0
137 stars 252 forks source link

[BUG] getPageOverlay hook was not converted to service in ext-solr 12.x #4151

Closed thomashohn closed 2 months ago

thomashohn commented 2 months ago

Describe the bug When debugging some 403 errors in the indexing of pages we discovered that the $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_page.php']['getPageOverlay'][CLASS] hook that was deprecated and removed with TYPO3 12 deprecation has not been converted into the corresponding PSR-14 Event and thus resulting in that the method getPageOverlay_preProcess is never called and processed

To Reproduce Steps to reproduce the behavior:

  1. Using the feature extendToSubpages results in that pages are not indexed properly

Expected behavior Pages should be indexed properly

Used versions (please complete the following information):

Additional context By inspecting the code I believe this has been properly solved in TYPO3 13 by adding the attribute

[AsEventListener

dkd-kaehm commented 2 months ago

Fixed in #4152 for release-12.0.x. In main branch aka TYPO3 13 it was fixed by f859f0c5b8fcf8c52f978267015b875568667afc