Reduce call get available sites for TYPO3 12.4

TYPO3-Solr / ext-solr

A TYPO3 extension that integrates the Apache Solr search server with TYPO3 CMS. dkd Internet Service GmbH is developing the extension. Community contributions are welcome. See CONTRIBUTING.md for details.

GNU General Public License v3.0

137 stars 252 forks source link

Reduce call get available sites for TYPO3 12.4 #4154

Open sfroemkenjw opened 2 months ago

sfroemkenjw commented 2 months ago

What this pr does?

Use PHP generator with yield to process just the available sites needed How to test

With over 300 root pages it needs over 30 seconds to build up all available sites. With help of a PHP generator we can stop processing all available sites if just the first site is requested. It's also helpful to just check, if there are available sites.

This should speed up performance a lot.

sfroemkenjw commented 2 months ago

Related to PR: #4145

dkd-kaehm commented 2 months ago

@sfroemkenjw Thanks for resolving that issue. Please squash to single commit.

sfroemkenjw commented 2 months ago

Hi @dkd-kaehm

I don't understand. After your approval you will get 3 options to merge my PR: Merge, Rebase and Squash. In TYPO3 docs team we always work this way. I have no clue how to squash commits on my side.

Stefan

dkd-kaehm commented 2 months ago

OK I'll do the squash. I have a question on one change.