search

TYPO3-Solr / ext-solr

A TYPO3 extension that integrates the Apache Solr search server with TYPO3 CMS. dkd Internet Service GmbH is developing the extension. Community contributions are welcome. See CONTRIBUTING.md for details.
GNU General Public License v3.0
136 stars 248 forks source link

[TASK:T13] fix mount-pages issues #4160

Open dkd-kaehm opened 1 month ago

dkd-kaehm commented 1 month ago 
1) ApacheSolrForTypo3\Solr\Tests\Integration\ConnectionManagerTest::canFindSolrConnectionForMountedPageIfMountPointIsGiven
ApacheSolrForTypo3\Solr\NoSolrConnectionFoundException: Could not find a Solr connection for page [24] and language [0].

/home/runner/work/ext-solr/ext-solr/.Build/vendor/typo3/cms-core/Classes/Utility/GeneralUtility.php:2808
/home/runner/work/ext-solr/ext-solr/Classes/ConnectionManager.php:231
/home/runner/work/ext-solr/ext-solr/Classes/ConnectionManager.php:206
/home/runner/work/ext-solr/ext-solr/Classes/ConnectionManager.php:118
/home/runner/work/ext-solr/ext-solr/Tests/Integration/ConnectionManagerTest.php:219

--

2) ApacheSolrForTypo3\Solr\Tests\Integration\IndexQueue\FrontendHelper\PageIndexerTest::canIndexMountedPage
Could not find content from mounted page in solr
Failed asserting that '{\n
  "responseHeader":{\n
    "status":0,\n
    "QTime":0,\n
    "params":{\n
      "q":"*:*"}},\n
  "response":{"numFound":0,"start":0,"numFoundExact":true,"docs":[]\n
  }}\n
' [ASCII](length: 161) contains ""title":"FirstShared (Not root)"" [ASCII](length: 32).

/home/runner/work/ext-solr/ext-solr/Tests/Integration/IndexQueue/FrontendHelper/PageIndexerTest.php:316

3) ApacheSolrForTypo3\Solr\Tests\Integration\IndexQueue\FrontendHelper\PageIndexerTest::canIndexMultipleMountedPage
Unexpected amount of documents in the core
Failed asserting that '{\n
  "responseHeader":{\n
    "status":0,\n
    "QTime":0,\n
    "params":{\n
      "q":"*:*"}},\n
  "response":{"numFound":0,"start":0,"numFoundExact":true,"docs":[]\n
  }}\n
' [ASCII](length: 161) contains ""numFound":2" [ASCII](length: 12).

/home/runner/work/ext-solr/ext-solr/Tests/Integration/IndexQueue/FrontendHelper/PageIndexerTest.php:351
dkd-friedrich commented 1 week ago

Issues of PageIndexerTest are resolved.

ConnectionManagerTest::canFindSolrConnectionForMountedPageIfMountPointIsGiven still fails, IMHO a bug in RootlineUtility->generateRootlineCache() is causing this. The pid of the mounted page is used for the root line instead of the mount page pid like in former issues, see https://github.com/TYPO3/typo3/commit/820c26fafd109ba20bb72dfcf407036fa7af4e08

We should investigate and discuss this behavior.