TYPO3-Solr / ext-solr

A TYPO3 extension that integrates the Apache Solr search server with TYPO3 CMS. dkd Internet Service GmbH is developing the extension. Community contributions are welcome. See CONTRIBUTING.md for details.
GNU General Public License v3.0
137 stars 252 forks source link

[TASK] Adjust mount point indexing #4195

Open dkd-friedrich opened 1 month ago

dkd-friedrich commented 1 month ago

Mount point indexing and corresponding tests have been adjusted for TYPO3 13. Mount points are supported in general and the mounted pages will be indexed like standard pages.

But there are some points to consider:

Test procedure in PageIndexerTest has been improved and now uses the PageUriBuilder to build the url to index, instead of building the url in the test itself.

Resolves: https://github.com/TYPO3-Solr/ext-solr/issues/4160

dkd-friedrich commented 1 month ago

Test ConnectionManagerTest::canFindSolrConnectionForMountedPageIfMountPointIsGiven is still disabled and fails.

Reason is probably a bug in RootlineUtility->generateRootlineCache(), as the pid of the mounted page is used for the root line instead of the mount page pid like in former versions. We should investigate and discuss this behavior.

dkd-friedrich commented 1 month ago

Is there a issue in forge for trouble in RootlineUtility->generateRootlineCache()?

Yes, I've created an issue and prepared a patch, see https://forge.typo3.org/issues/105376

dkd-friedrich commented 1 month ago

I am postponing work on this problem until we receive feedback in https://forge.typo3.org/issues/105376.

Our further action depends on whether the patch is adopted.