search

TYPO3-Solr / ext-solr

A TYPO3 extension that integrates the Apache Solr search server with TYPO3 CMS. dkd Internet Service GmbH is developing the extension. Community contributions are welcome. See CONTRIBUTING.md for details.
GNU General Public License v3.0
137 stars 252 forks source link

[TASK] Do not ignore database exceptions #4200

Open christophlehmann opened 1 month ago

christophlehmann commented 1 month ago

What this pr does

This removes a try catch block around a select query.

When a database query is not okay for any reason, then i like to get the reason directly.

Fixes: #4199

masi commented 3 weeks ago

I agree that muted exceptions are a no-go, but IMHO a proper handling is much better than letting the application break with an unhandled exception. And there are already enough of completely unhelpful stack traces in logs created by Solr.

I suggest at least logging the SQL statement and the context in some readable manner before letting the calling code choke on the exception.