search

TYPO3-coreapi / ext-coreapi

http://forge.typo3.org/projects/show/extension-coreapi
61 stars 38 forks source link

Compatibility with 6.2.x #39

Closed etobi closed 10 years ago

madsbrunn commented 11 years ago

Would like to accomplish this without a lot of "if (t3lib_div::compat_version('6.0.0')) {}"

etobi commented 11 years ago

yaeh. right. Actually EXT:coreapi is supposed to be that abstraction/compatibility layer to have the same API in 4.5-6.x.

Maybe we could implement different versions of the ServiceAPIs (one for 4.5, another for 6.0 and one more for 6.2, ...) and load that right one.

What do you think?

madsbrunn commented 11 years ago

Are there major changes in the API from 6.0 to 6.2? I hope not!

Anyways, yes. Create different versions of the service api's and pick the right one in the array returned by the ext_autoload.php file

= no t3lib_div::compat_version(...) calls in the code!

etobi commented 11 years ago

Are there major changes in the API from 6.0 to 6.2? I hope not!

I guess there will be changes (Installtool, maybe ExtensionManager API?)

Our DatabaseApiService is already using tx_install, tx_install_Sql or "TYPO3\CMS\Install\Sql\SchemaMigrator" depending on the core version.

etobi commented 11 years ago

I would love to have the following implementation:

christophlehmann commented 11 years ago

What about a branch for 6.X?

madsbrunn commented 11 years ago

That was also my original thought but if at some point EXT:coreapi is going into the TER it will be difficult to have two branches of the same extension co-exist there.

Besides, not all API's have changed in 6.x so we don't need to have version-specific classes for all service classes.

2013/7/16 christophlehmann notifications@github.com

What about a branch for 6.X?

— Reply to this email directly or view it on GitHubhttps://github.com/etobi/ext-coreapi/issues/39#issuecomment-21036182 .

etobi commented 11 years ago

Hej,

yes, a TER release might happen at some point.

Plus: I really want to avoid having multiple versions of EXT:coreapi depending on from which source (e.g. different branches) its installed (--> support hell)

etobi commented 11 years ago

check my suggested implementation in https://github.com/etobi/ext-coreapi/tree/refactorServiceClasses

Feedback appreciated.

peterkraume commented 10 years ago

What's the current status of 6.2 compatibility? Is there anything I can do to help?

johannessteu commented 10 years ago

Same here. What has to get done to tag it for 6.2?

etobi commented 10 years ago

You might want to contact https://twitter.com/konafets and https://twitter.com/foertel. They going to do a Google Summer of Code project on this. Also check Georg Ringers fork here: https://github.com/georgringer/ext-coreapi

mgrundkoetter commented 9 years ago

Still does not work, because the cliKey is not configured. Even if I use the existing 6.2 branch from Github, it does not work. The cliKey is shown then, but nothing happens if its called...

Konafets commented 9 years ago

Can you provide an example command which doesn't work?

mgrundkoetter commented 9 years ago

Every command does not work as it is not even possible to just call it. When you call typo3/cli_dispatch.phpsh on the console, the key coreapi is not available, until I modify the ext_localconf.php a little bit. It works fine with 4.5, but in 6.2 it does nothing.

Konafets commented 9 years ago

There ist no key coreapi. You need to use the key extbase. The following command will give you an overview over all available commands provided by the extbase key. You will find the commands from ext:coreapi at the very end.

$ ./typo3/cli_dispatch.phpsh extbase help
mgrundkoetter commented 9 years ago

Neither "typo3/cli_dispatch.phpsh extbase" nor "typo3/cli_dispatch.phpsh extbase help" produce any output (and no error as well). And yes, there is a BE user with the name _cli_lowlevel who does not have admin privileges.

Konafets commented 9 years ago

I can't reproduce this issue. I deactivated my clilowlevel user but then I got the error message "ERROR: No backend user named "_cli_lowlevel" was found!", which is correct. After activating this user again the cli is working for me. clilowlevel is - beside normal admin user - the only user in the system.

The fact that you get no output et all indicates a more generic issue, which is independent from ext:coreapi.

Which output produces 

$ ./typo3/cli_dispatch.phpsh
mgrundkoetter commented 9 years ago

Hehe, good idea. Seems to be php 5.5! Or better TYPO3 does not like 5.5 on cli. When I try with 5.4 everything is fine again. So I guess it is about the extbase task on cli in combination with php5.5. I guess there is a pass-by-reference-variable in there somewhere. You have something < 5.5 I guess?

Konafets commented 9 years ago

Nope. Actually TYPO3 works fine with PHP 5.5

php -v                                                                                                                  
PHP 5.5.19 (cli) (built: Nov 15 2014 20:08:25)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
    with Xdebug v2.2.5, Copyright (c) 2002-2014, by Derick Rethans
    with Suhosin v0.9.36, Copyright (c) 2007-2014, by SektionEins GmbH