search

TYPO3 / CmsComposerInstallers

TYPO3 CMS Composer Installer
GNU General Public License v2.0
58 stars 39 forks source link

Replace PHP version constraints in entry point scripts #111

Closed gilbertsoft closed 3 years ago

gilbertsoft commented 3 years ago

The change https://review.typo3.org/c/Packages/TYPO3.CMS/+/67365 introduces also an upper check for the PHP version. Imho it could make sense if we replace the PHP versions during the entry point setup here in https://github.com/TYPO3/CmsComposerInstallers/blob/master/src/Plugin/Core/InstallerScripts/EntryPoint.php.

helhum commented 3 years ago

The code here only changes the require line and leaves the rest of the file as is. Therefore no change is required here.

helhum commented 3 years ago

oh, if you mean replacing the version check dynamically with the Composer constraints, then I'd disagree to change anything here as well and rather rely on the functionality Composer introduced.

gilbertsoft commented 3 years ago

rather rely on the functionality Composer introduced

And what's that? Did you see the discussion at Slack, linked from the core patch above. The idea was to get a clear error in the entry scripts by checking the version constraints. And for a Composer install it would imho make sense to use the Composer constraints therefor.

helhum commented 3 years ago

The idea was to get a clear error in the entry scripts by checking the version constraints. And for a Composer install it would imho make sense to use the Composer constraints therefor.

That is precisely Composer 2.0 runtime functionality. Check TYPO3 Console 6.0 to see it in action.

Implementing that for TYPO3 is a matter of a single requirement change (making Composer 2.0 mandatory) and removal of our own checks.

helhum commented 3 years ago

See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67371