TYPO3 / CmsComposerInstallers

TYPO3 CMS Composer Installer
GNU General Public License v2.0
58 stars 39 forks source link

Documentation is treated as extension #139

Closed linawolf closed 2 years ago

linawolf commented 2 years ago

All Official TYPO3 manuals have the type

    "type": "typo3-cms-documentation",

After the update to typo3/cms-composer-installers v5.0 manuals are however treated like extensions which they are not. Therefore there is an error thrown in ExtensionKeyResolver:

Extension with package name "typo3/reference-coreapi" does not define an extension key.
helhum commented 2 years ago

Thanks. Hm, I have multiple questions:

helhum commented 2 years ago

To clarify: Technically, since a very long time, packages with a type that starts with typo3-cms- are TYPO3 extensions and are treated the same for a very long time already.

linawolf commented 2 years ago

We do install typo3 into the manuals so we can use CLI commands to create the codesnippets or screenshots.

This worked well until the update to v5 of the composer installer. No warnings displayed.

Have a look here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/blob/main/composer.json

linawolf commented 2 years ago

The type "typo3-cms-documentation" is required to have the documentation render.

ohader commented 2 years ago

The type "typo3-cms-documentation" is required to have the documentation render.

Why is that? Where is that required? I could not find any type typo3-cms-documentation on packagist.org (https://packagist.org/?type=typo3-cms-documentation)

linawolf commented 2 years ago

It is required in the rendering pipeline as far as I understand, Maybe @marble can enlighten us here? No the documentation is not on packagist (yet)

linawolf commented 2 years ago

Can be solved by just defining an extension key... Seems like I didnt see the solution right before my eyes. There is no harm in defining one...